Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: fix upgrade to npm 3.3.6 #3494

Closed
wants to merge 1 commit into from
Closed

Conversation

iarna
Copy link
Member

@iarna iarna commented Oct 23, 2015

This adds the debug dep back in for [email protected]. I'll PR separately for fixing the .gitigore to not cause this problem again. This will resolve the problem in #3493

@jbergstroem
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-commit/924/

Edit: fix CI link.
Edit2: had to cancel and resubmit, link updated.

@jbergstroem jbergstroem added the npm Issues and PRs related to the npm client dependency or the npm registry. label Oct 23, 2015
@evanlucas
Copy link
Contributor

CI looks good (minus the tests that have been failing pretty consistently lately)

LGTM

@jasnell
Copy link
Member

jasnell commented Oct 23, 2015

LGTM. Will get this landed now so CI can get back on track

jasnell pushed a commit that referenced this pull request Oct 23, 2015
41923c0 broke things. This fixes them.

Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
PR-URL: #3494
@jasnell
Copy link
Member

jasnell commented Oct 23, 2015

Landed in 68471dd

@jasnell jasnell closed this Oct 23, 2015
rvagg pushed a commit that referenced this pull request Oct 26, 2015
41923c0 broke things. This fixes them.

Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
PR-URL: #3494
@rvagg rvagg mentioned this pull request Dec 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants