Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: make minor improvements to query string sentence in http2.md #34929

Merged
merged 1 commit into from
Aug 29, 2020
Merged

doc: make minor improvements to query string sentence in http2.md #34929

merged 1 commit into from
Aug 29, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 26, 2020

Checklist

@Trott Trott requested review from a team as code owners August 26, 2020 05:41
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Aug 26, 2020
lundibundi
lundibundi approved these changes Aug 26, 2020
View reviewed changes
doc/api/http2.md Show resolved Hide resolved
@Trott Trott mentioned this pull request Aug 28, 2020
Merged
2 tasks
@Trott Trott added the review wanted PRs that need reviews. label Aug 29, 2020
@Trott
Copy link
Member Author

Trott commented Aug 29, 2020

Landed in c2996ce

@Trott Trott merged commit c2996ce into nodejs:master Aug 29, 2020
@Trott Trott deleted the obtain branch August 29, 2020 15:01
Trott added a commit to Trott/io.js that referenced this pull request Aug 30, 2020
@Trott
doc: replace require() with reference links in http2.md
07e7ad9 
Refs: nodejs#34929 (comment)

PR-URL: nodejs#34956
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
richardlau pushed a commit that referenced this pull request Sep 1, 2020
@Trott @richardlau
doc: make minor improvements to query string sentence in http2.md
31098a4 
PR-URL: #34929
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
richardlau pushed a commit that referenced this pull request Sep 1, 2020
@Trott @richardlau
doc: replace require() with reference links in http2.md
94c6e09 
Refs: #34929 (comment)

PR-URL: #34956
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
@richardlau richardlau mentioned this pull request Sep 2, 2020
Merged
4 tasks
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
doc: make minor improvements to query string sentence in http2.md
bf1dcc9 
PR-URL: #34929
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
doc: make minor improvements to query string sentence in http2.md
0695e24 
PR-URL: #34929
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lundibundi lundibundi lundibundi approved these changes

@rickyes rickyes rickyes approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. review wanted PRs that need reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @nodejs-github-bot @lundibundi @rickyes