Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: run link checker in linter workflow #34810

Closed
wants to merge 2 commits into from

Conversation

richardlau
Copy link
Member

Run the checkLinks.js tool on our actions workflow.
Change format of logged messages when run on GitHub Actions (i.e.
when the GITHUB_ACTIONS environment variable is true) so that
broken links are highlighted inline in pull requests.

Refs: #34787

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Aug 17, 2020
@richardlau richardlau added the blocked PRs that are blocked by other issues or PRs. label Aug 17, 2020
@richardlau

This comment has been minimized.

@richardlau richardlau added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed blocked PRs that are blocked by other issues or PRs. labels Aug 17, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 17, 2020
@nodejs-github-bot

This comment has been minimized.

Change format of logged messages when run on GitHub Actions (i.e.
when the `GITHUB_ACTIONS` environment variable is true) so that
broken links are highlighted inline in pull requests.

Signed-off-by: Richard Lau <[email protected]>
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 17, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 17, 2020
@nodejs-github-bot
Copy link
Collaborator

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 19, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 19, 2020
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/34810
✔  Done loading data for nodejs/node/pull/34810
----------------------------------- PR info ------------------------------------
Title      build: run link checker in linter workflow (#34810)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     richardlau:checklinks -> nodejs:master
Labels     author ready, doc, meta, tools
Commits    2
 - build: run link checker in linter workflow
 - doc,tools: annotate broken links in actions workflow
Committers 1
 - Richard Lau 
PR-URL: https://github.com/nodejs/node/pull/34810
Refs: https://github.com/nodejs/node/issues/34787
Reviewed-By: Mary Marchini 
Reviewed-By: James M Snell 
Reviewed-By: Jiawen Geng 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/34810
Refs: https://github.com/nodejs/node/issues/34787
Reviewed-By: Mary Marchini 
Reviewed-By: James M Snell 
Reviewed-By: Jiawen Geng 
--------------------------------------------------------------------------------
   ℹ  Last Full PR CI on 2020-08-17T20:12:30Z: https://ci.nodejs.org/job/node-test-pull-request/32814/
- Querying data of job/node-test-pull-request/32814/
✔  Build data downloaded
   ℹ  This PR was created on Mon, 17 Aug 2020 17:05:19 GMT
   ✔  Approvals: 3
   ✔  - Mary Marchini (@mmarchini) (TSC): https://github.com/nodejs/node/pull/34810#pullrequestreview-468672962
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/34810#pullrequestreview-468746762
   ✔  - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/34810#pullrequestreview-468943560
--------------------------------------------------------------------------------
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/master up to date...
From https://github.com/nodejs/node
 * branch              master     -> FETCH_HEAD
✔  origin/master is now up-to-date
- Downloading patch for 34810
✔  Downloaded patch to /home/runner/work/node/node/.ncu/34810/patch
--------------------------------------------------------------------------------
Applying: build: run link checker in linter workflow
Applying: doc,tools: annotate broken links in actions workflow
   ✔  Patches applied
There are 2 commits in the PR
Please run the following commands to complete landing

$ git rebase origin/master -i -x "git node land --amend"
$ git node land --continue

@github-actions github-actions bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Aug 19, 2020
@Trott
Copy link
Member

Trott commented Aug 19, 2020

Landed in be360e2...9a819dd

@Trott Trott closed this Aug 19, 2020
Trott pushed a commit that referenced this pull request Aug 19, 2020
Signed-off-by: Richard Lau <[email protected]>

PR-URL: #34810
Refs: #34787
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Trott pushed a commit that referenced this pull request Aug 19, 2020
Change format of logged messages when run on GitHub Actions (i.e.
when the `GITHUB_ACTIONS` environment variable is true) so that
broken links are highlighted inline in pull requests.

Signed-off-by: Richard Lau <[email protected]>

PR-URL: #34810
Refs: #34787
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott
Copy link
Member

Trott commented Aug 19, 2020

(Oh, I see the commit queue tag was added less than an hour ago. Hope I didn't jump the gun by landing it. Sorry if I've made it harder to debug the problem it was having!)

addaleax pushed a commit that referenced this pull request Sep 22, 2020
Signed-off-by: Richard Lau <[email protected]>

PR-URL: #34810
Refs: #34787
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Change format of logged messages when run on GitHub Actions (i.e.
when the `GITHUB_ACTIONS` environment variable is true) so that
broken links are highlighted inline in pull requests.

Signed-off-by: Richard Lau <[email protected]>

PR-URL: #34810
Refs: #34787
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
@targos targos removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants