test: skip node-api/test_worker_terminate_finalization #34732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test fails under ASAN/valgrind. Since it has not been working properly until today anyway, skip it. Refs: nodejs#34731
|
👍 to fast-track to unbreak test-asan? |
addaleax
added
fast-track
github-actions
bot
removed
the
request-ci
|
CI: https://ci.nodejs.org/job/node-test-pull-request/32735/ (:green_heart:) |
jasnell
approved these changes
Aug 11, 2020
mmarchini
approved these changes
Aug 12, 2020
mmarchini
pushed a commit
that referenced
this pull request
Aug 12, 2020
The test fails under ASAN/valgrind. Since it has not been working properly until today anyway, skip it. Refs: #34731 PR-URL: #34732 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
|
Landed in cf5d7c0 |
MylesBorins
pushed a commit
that referenced
this pull request
Aug 17, 2020
The test fails under ASAN/valgrind. Since it has not been working properly until today anyway, skip it. Refs: #34731 PR-URL: #34732 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Aug 20, 2020
The test fails under ASAN/valgrind. Since it has not been working properly until today anyway, skip it. Refs: #34731 PR-URL: #34732 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
addaleax
added a commit
that referenced
this pull request
Sep 22, 2020
The test fails under ASAN/valgrind. Since it has not been working properly until today anyway, skip it. Refs: #34731 PR-URL: #34732 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
addaleax
added a commit
that referenced
this pull request
Sep 22, 2020
The test fails under ASAN/valgrind. Since it has not been working properly until today anyway, skip it. Refs: #34731 PR-URL: #34732 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test fails under ASAN/valgrind. Since it has not been working
properly until today anyway, skip it.
Refs: #34731
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes