test: fix test_worker_terminate_finalization #34726
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was missing an initialization of the global `ref` variable because there was also an unused local one, leading to failures like the one seen in nodejs#34625.
addaleax
added
fast-track
github-actions
bot
removed
the
request-ci
|
Please 👍 to fast-track |
4 tasks
richardlau
approved these changes
Aug 11, 2020
|
Ok, now I'm really curious why this wasn't failing consistently in other CI runs! So happy you found this! |
jasnell
approved these changes
Aug 11, 2020
addaleax
added
the
author ready
rickyes
approved these changes
Aug 11, 2020
I think your PR changes GC timing in some way – previously, the finalizer was run during shutdown, where no JS calls are allowed anyway (i.e. the |
addaleax
added a commit
that referenced
this pull request
Aug 11, 2020
The test was missing an initialization of the global `ref` variable because there was also an unused local one, leading to failures like the one seen in #34625. PR-URL: #34726 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
|
Landed in 9f47e5a, thanks for the quick reviews! |
MylesBorins
pushed a commit
that referenced
this pull request
Aug 17, 2020
The test was missing an initialization of the global `ref` variable because there was also an unused local one, leading to failures like the one seen in #34625. PR-URL: #34726 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Aug 20, 2020
The test was missing an initialization of the global `ref` variable because there was also an unused local one, leading to failures like the one seen in #34625. PR-URL: #34726 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
addaleax
added a commit
that referenced
this pull request
Sep 22, 2020
The test was missing an initialization of the global `ref` variable because there was also an unused local one, leading to failures like the one seen in #34625. PR-URL: #34726 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
addaleax
added a commit
that referenced
this pull request
Sep 22, 2020
The test was missing an initialization of the global `ref` variable because there was also an unused local one, leading to failures like the one seen in #34625. PR-URL: #34726 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was missing an initialization of the global
refvariablebecause there was also an unused local one, leading to failures
like the one seen in #34625.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes