Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: revise onboarding-extras #34496

Merged
merged 0 commits into from
Jul 26, 2020
Merged

doc: revise onboarding-extras #34496

merged 0 commits into from
Jul 26, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 23, 2020

Revise onboarding-extras for style guide conformance and minor wording
improvements.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 23, 2020
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 24, 2020
@Trott
Copy link
Member Author

Trott commented Jul 25, 2020

This could use a second review. @nodejs/documentation

@Trott
Copy link
Member Author

Trott commented Jul 26, 2020

Landed in c38bb43

@Trott Trott closed this Jul 26, 2020
@Trott Trott merged commit c38bb43 into nodejs:master Jul 26, 2020
@Trott Trott deleted the onb-ext branch July 26, 2020 02:18
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
Revise onboarding-extras for style guide conformance and minor wording
improvements.

PR-URL: #34496
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Revise onboarding-extras for style guide conformance and minor wording
improvements.

PR-URL: #34496
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Revise onboarding-extras for style guide conformance and minor wording
improvements.

PR-URL: #34496
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants