-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: repl-persistent-history is no longer flaky #3437
Conversation
LGTM |
CI on |
Potentially unrelated failures in CI need to be verified. Otherwise LGTM. |
Windows is all net-related stuff, mostly PPC:
Seem unrelated? Another run: https://ci.nodejs.org/job/node-test-pull-request/535/ |
@Fishrock123 unrelated; #3390 |
LGTM |
e1d896d
to
0c38ce4
Compare
The race conditions were fixed in 286ef1d PR-URL: nodejs#3437 Reviewed By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
0c38ce4
to
5923dee
Compare
Thanks, landed in 5923dee I should probably look at having this run in |
The race conditions were fixed in 286ef1d PR-URL: #3437 Reviewed By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
this should be considered for LTS /cc @jasnell |
The race conditions were fixed in 286ef1d PR-URL: #3437 Reviewed By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
Landed in v4.x-staging in 3d1f57d |
@jasnell you landed the related fix(es) right? |
@Fishrock123 .. thanks for the reminder... #2356 (comment) |
The race conditions were fixed in 286ef1d PR-URL: #3437 Reviewed By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
The race conditions were fixed in
286ef1d
R=@evanlucas?