Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quic: another, another round of quic cleanups #34262

Closed
wants to merge 3 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jul 8, 2020

Builds on #34247 ... the first 15 commits in this PR are from that one.... that one needs to land first.

This is a WIP, will be adding more commits

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jul 8, 2020
@jasnell jasnell force-pushed the quic-cleanups-5 branch 2 times, most recently from d862211 to e36d749 Compare July 8, 2020 18:43
Stop the madness. Only you can prevent excessive error code
proliferation.
@jasnell jasnell marked this pull request as ready for review July 9, 2020 17:57
@jasnell jasnell requested a review from a team July 9, 2020 17:57
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 9, 2020

lib/internal/quic/core.js Show resolved Hide resolved
jasnell added a commit that referenced this pull request Jul 10, 2020
Stop the madness. Only you can prevent excessive error code
proliferation.

PR-URL: #34262
Reviewed-By: Anna Henningsen <[email protected]>
jasnell added a commit that referenced this pull request Jul 10, 2020
jasnell added a commit that referenced this pull request Jul 10, 2020
@jasnell
Copy link
Member Author

jasnell commented Jul 10, 2020

Landed in 5e769b2, 48a349e, and c176d5f

@MylesBorins
Copy link
Contributor

Marked as "backport-requested" because I do not believe quic is on 14.x yet. Should we change the label to "dont-land"?

@jasnell
Copy link
Member Author

jasnell commented Jul 14, 2020

@MylesBorins for the time being, none of the quic related PRs/commits should be pulled into any release lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants