src: refactor TimerWrap class #34252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There’s no point in having an opaque user data pointer when we’re already using `std::function`.
nodejs-github-bot
added
c++
jasnell
approved these changes
Jul 8, 2020
Split `Stop(true)` and `Stop(false)` into separate methods since the actions performed by these are fully distinct.
addaleax
force-pushed
the
timer-wrap-cleanup
branch
from
d913186
to
76c6697
Compare
|
@jasnell So it turned out there is a reason why the cleanup hook is on the |
himself65
approved these changes
Jul 8, 2020
devnexen
approved these changes
Jul 9, 2020
addaleax
added
the
author ready
|
CI: https://ci.nodejs.org/job/node-test-pull-request/32265/ (:green_heart:) |
addaleax
added a commit
that referenced
this pull request
Jul 14, 2020
There’s no point in having an opaque user data pointer when we’re already using `std::function`. PR-URL: #34252 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: David Carlier <[email protected]>
addaleax
added a commit
that referenced
this pull request
Jul 14, 2020
Split `Stop(true)` and `Stop(false)` into separate methods since the actions performed by these are fully distinct. PR-URL: #34252 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: David Carlier <[email protected]>
|
Landed in 18667ac...874460a |
|
This does not land cleanly on v14.x, should this be backported? |
cjihrig
pushed a commit
that referenced
this pull request
Jul 23, 2020
There’s no point in having an opaque user data pointer when we’re already using `std::function`. PR-URL: #34252 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: David Carlier <[email protected]>
cjihrig
pushed a commit
that referenced
this pull request
Jul 23, 2020
Split `Stop(true)` and `Stop(false)` into separate methods since the actions performed by these are fully distinct. PR-URL: #34252 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: David Carlier <[email protected]>
targos
added
backported-to-v14.x
and removed
author ready
targos
pushed a commit
that referenced
this pull request
May 1, 2021
There’s no point in having an opaque user data pointer when we’re already using `std::function`. PR-URL: #34252 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: David Carlier <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Split `Stop(true)` and `Stop(false)` into separate methods since the actions performed by these are fully distinct. PR-URL: #34252 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: David Carlier <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src: remove user_data from TimerWrap
There’s no point in having an opaque user data pointer when we’re
already using
std::function.src: refactor TimerWrap lifetime management
Move the cleanup hook into thesplitTimerWrap, because it shouldalways be present when that class is being used, and
Stop(true)andStop(false)into separate methods since theactions performed by these are fully distinct.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes