Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: added big-endian check and support to UTF-16 encode #3410

Closed
wants to merge 1 commit into from
Closed

src: added big-endian check and support to UTF-16 encode #3410

wants to merge 1 commit into from

Commits on Oct 30, 2015

  1. src: Added for loop to Encode function to support big-endian machines. 

    Versions of Node.js after v0.12 have relocated byte-swapping away from
the StringBytes::Encode function, thereby causing a nan test (which accesses
this function directly) to fail on big-endian machines.

This change re-introduces byte swapping in StringBytes::Encode,
done via a call to a function in util-inl. Another change in
NodeBuffer::StringSlice was necessary to avoid double byte swapping
in big-endian function calls to StringSlice.
    @exinfinitum
    exinfinitum committed Oct 30, 2015
    Configuration menu
    Copy the full SHA
    fb26b51 View commit details
    Browse the repository at this point in the history