Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add non-ASCII character embedding test #33972

Closed
wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

Add a test that verifies that non-ASCII characters may be used
in the source code provided to LoadEnvironment().

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Add a test that verifies that non-ASCII characters may be used
in the source code provided to `LoadEnvironment()`.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 19, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 19, 2020

@addaleax addaleax added the embedding Issues and PRs related to embedding Node.js in another project. label Jun 19, 2020
@addaleax
Copy link
Member Author

Okay, fixed up the test here because whether V8 accepts 𝒂 in an identifier depends on whether intl is enabled or not … ;) I’m glad that all our compilers seem to be okay here, though.

@nodejs-github-bot
Copy link
Collaborator

1 similar comment
@addaleax
Copy link
Member Author

@nodejs-github-bot
Copy link
Collaborator

jasnell pushed a commit that referenced this pull request Jun 26, 2020
Add a test that verifies that non-ASCII characters may be used
in the source code provided to `LoadEnvironment()`.

PR-URL: #33972
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jun 26, 2020

Landed in db6e6e3

@jasnell jasnell closed this Jun 26, 2020
codebytere pushed a commit that referenced this pull request Jun 27, 2020
Add a test that verifies that non-ASCII characters may be used
in the source code provided to `LoadEnvironment()`.

PR-URL: #33972
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request Jun 28, 2020
codebytere pushed a commit that referenced this pull request Jun 30, 2020
Add a test that verifies that non-ASCII characters may be used
in the source code provided to `LoadEnvironment()`.

PR-URL: #33972
Reviewed-By: James M Snell <[email protected]>
addaleax added a commit that referenced this pull request Sep 23, 2020
Add a test that verifies that non-ASCII characters may be used
in the source code provided to `LoadEnvironment()`.

PR-URL: #33972
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. embedding Issues and PRs related to embedding Node.js in another project. review wanted PRs that need reviews. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants