Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: apply correct assert.fail() arguments #3378

Closed
wants to merge 1 commit into from
Closed

test: apply correct assert.fail() arguments #3378

wants to merge 1 commit into from

Commits on Oct 15, 2015

  1. test: apply correct assert.fail() arguments 

    The assert.fail function signature has the message as the third argument
but, understandably, it is often assumed that it is the first argument
(or at least the first argument if no other arguments are passed).

This corrects the assert.fail() invocations in the Node.js tests.

Before:
assert.fail('message');
// result: AssertionError: 'message' undefined undefined

After:
assert.fail(null, null, 'message');
// result: AssertionError: message
    @Trott
    Trott committed Oct 15, 2015
    Configuration menu
    Copy the full SHA
    6b90d86 View commit details
    Browse the repository at this point in the history