Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add formatting for version numbers to doc-style-guide.md #33755

Closed
wants to merge 0 commits into from
Closed

doc: add formatting for version numbers to doc-style-guide.md #33755

wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 5, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 5, 2020
lpinca
lpinca approved these changes Jun 5, 2020
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM even though node -v prints v14.4.0.

@Trott
Copy link
Member Author

Trott commented Jun 5, 2020

LGTM even though node -v prints v14.4.0.

Yeah, there are a few places where the v will live on forever probably, and that's OK.

@addaleax
Copy link
Member

addaleax commented Jun 5, 2020

@lpinca The docs also use vX.Y.Z for the changelog markers, but this PR specifically says that this rule is for prose text, so I think that’s okay.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 5, 2020
Trott added a commit that referenced this pull request Jun 7, 2020
@Trott
doc: add formatting for version numbers to doc-style-guide.md
eeede81 
PR-URL: #33755
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jun 7, 2020

Landed in eeede81

@Trott Trott closed this Jun 7, 2020
@Trott Trott deleted the no-v branch June 7, 2020 19:34
Trott added a commit to Trott/io.js that referenced this pull request Jun 8, 2020
@Trott
doc: disable md-linting for a line in the style guide
e9f8560 
Linting the style guide is failing due to a recent addition in
nodejs#33755 landing before the lint
library being updated in nodejs#33727.
Sorry about the error.
@Trott Trott mentioned this pull request Jun 8, 2020
Closed
3 tasks
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@Trott @codebytere
doc: add formatting for version numbers to doc-style-guide.md
095efac 
PR-URL: #33755
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@Trott @codebytere
doc: add formatting for version numbers to doc-style-guide.md
83f499b 
PR-URL: #33755
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
codebytere pushed a commit that referenced this pull request Jul 9, 2020
@Trott @codebytere
doc: add formatting for version numbers to doc-style-guide.md
3b43741 
PR-URL: #33755
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Jul 13, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 14, 2020
@Trott @codebytere
doc: add formatting for version numbers to doc-style-guide.md
2db875c 
PR-URL: #33755
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @addaleax @lpinca @richardlau @trivikr @nodejs-github-bot