-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix deprecation "End-of-Life" capitalization #33691
Merged
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
deprecations
Issues and PRs related to deprecations.
doc
Issues and PRs related to the documentations.
labels
Jun 1, 2020
richardlau
approved these changes
Jun 2, 2020
I thought we linted for this? |
@Trott I think these would have been caught by the linter prior to nodejs/remark-preset-lint-node#86? |
MrHeer
approved these changes
Jun 2, 2020
targos
approved these changes
Jun 2, 2020
👍 to fast-track |
lpinca
approved these changes
Jun 2, 2020
Update the "End-of-Life" casing in the deprecation documentation for consistency. Similar to nodejs#26251. PR-URL: nodejs#33691 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Bug identified. Fix coming soon, I think/hope. |
Trott
added a commit
to Trott/remark-lint-prohibited-strings
that referenced
this pull request
Jun 4, 2020
Trott
added a commit
to Trott/remark-lint-prohibited-strings
that referenced
this pull request
Jun 4, 2020
Trott
added a commit
to Trott/remark-lint-prohibited-strings
that referenced
this pull request
Jun 4, 2020
Trott
added a commit
to Trott/remark-preset-lint-node
that referenced
this pull request
Jun 4, 2020
This fixes a bug that causes remark-preset-lint-node to miss some errors. Refs: nodejs/node#33691
Trott
added a commit
to nodejs/remark-preset-lint-node
that referenced
this pull request
Jun 4, 2020
This fixes a bug that causes remark-preset-lint-node to miss some errors. Refs: nodejs/node#33691
Marlyfleitas
added a commit
to Marlyfleitas/Node-remark-preset-lint
that referenced
this pull request
Aug 26, 2022
This fixes a bug that causes remark-preset-lint-node to miss some errors. Refs: nodejs/node#33691
patrickm68
added a commit
to patrickm68/Node-preset-lint
that referenced
this pull request
Sep 14, 2023
This fixes a bug that causes remark-preset-lint-node to miss some errors. Refs: nodejs/node#33691
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
deprecations
Issues and PRs related to deprecations.
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the "End-of-Life" casing in the deprecation documentation for consistency. Similar to #26251.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes