Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update events docs for consistency #33678

Merged
merged 2 commits into from
Jun 2, 2020
Merged

doc: update events docs for consistency #33678

merged 2 commits into from
Jun 2, 2020

Commits on Jun 2, 2020

  1. doc: remove "it is important" 

    In the spirit of nodejs#30108, remove the use of "it is important" in
the new EventTarget docs.

PR-URL: nodejs#33678
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
    @cjihrig
    cjihrig committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    d534052 View commit details
    Browse the repository at this point in the history

  2. doc: use consistent Default: in events 

    The API docs have been migrating to **Default:** when providing
default values. This commit updates the events documentation page
for consistency.

PR-URL: nodejs#33678
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
    @cjihrig
    cjihrig committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    16eaacf View commit details
    Browse the repository at this point in the history