-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
events: expose Event statics #33649
events: expose Event statics #33649
Conversation
Also I did not fix the tests at the top that check |
static NONE = 0; | ||
static CAPTURING_PHASE = 1; | ||
static AT_TARGET = 2; | ||
static BUBBLING_PHASE = 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a comment in here that we currently do not use the CAPTURING_PHASE
and BUBBLING_PHASE
but that they need to be preserved anyway because of the spec would be good.
8ae28ff
to
2935f72
Compare
Co-authored-by: James M Snell <[email protected]>
Adding a fixup commit resolving the rebase conflict. |
@benjamingr ... can I ask to you squash the commits here? |
Sure though I have a computer without built node so I am doing everything "blind" until early next week. |
@jasnell I see there is a merge commit present - I assume that's not intentional? Can I pluck it out and squash the other two? |
Actually, don't worry about squashing or fixing up. I'm combining all these PRs into a single PR to make landing them easier |
@jasnell to be explicit, you have my explicit consent (and blessing) to do as you wish with the code here and in the other PRs (and in follow up event-target PRs when I get back to my workstation next week). |
Closing in favor of #34015 (which combines this and other |
Expose Event statics (Event.NONE etc). See Event phase constants.
I think these are required on the event interface (as constants).
They are as-enumerable as they are in browsers though I did not add a specific test for enumerability (I can if people feel strongly about it)
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes