Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: fix spellings in the comment #33635

Closed
wants to merge 1 commit into from
Closed

stream: fix spellings in the comment #33635

wants to merge 1 commit into from

Conversation

antsmartian
Copy link
Contributor

Just found these nits while seeing the source code, thought will clean them up. Can be fast-tracked (if needed).

/cc @nodejs/streams

@nodejs-github-bot nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label May 29, 2020
himself65
himself65 approved these changes May 29, 2020
View reviewed changes
lib/_stream_transform.js Outdated Show resolved Hide resolved
mcollina
mcollina requested changes May 29, 2020
View reviewed changes
lib/_stream_readable.js Outdated Show resolved Hide resolved
@antsmartian antsmartian changed the title stream: remove unused param and fix spellings stream: fix spellings in the comment May 29, 2020
mcollina
mcollina approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@himself65
Copy link
Member

Still LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31624/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 30, 2020
@BridgeAR BridgeAR force-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72 Compare May 31, 2020 12:18
This was referenced Jun 4, 2020
Closed
Open
Open
Open
Open
mcollina
mcollina approved these changes Jun 7, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

mcollina commented Jun 7, 2020

Landed in 08892fc

@mcollina mcollina closed this Jun 7, 2020
mcollina pushed a commit that referenced this pull request Jun 7, 2020
@antsmartian @mcollina
stream: fix the spellings
08892fc 
PR-URL: #33635
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
This was referenced Jun 8, 2020
Open
Open
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@antsmartian @codebytere
stream: fix the spellings
b0fa611 
PR-URL: #33635
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@antsmartian @codebytere
stream: fix the spellings
9246283 
PR-URL: #33635
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
codebytere pushed a commit that referenced this pull request Jul 9, 2020
@antsmartian @codebytere
stream: fix the spellings
62edaae 
PR-URL: #33635
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Jul 13, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 14, 2020
@antsmartian @codebytere
stream: fix the spellings
1a5ef19 
PR-URL: #33635
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himself65 himself65 himself65 approved these changes

@MrHeer MrHeer MrHeer approved these changes

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@ronag ronag ronag approved these changes

@lpinca lpinca lpinca approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@antsmartian @himself65 @nodejs-github-bot @mcollina @lpinca @ronag @BridgeAR @trivikr @MrHeer