events: add tests, better toString #33622
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamingr
added
the
events
jasnell
approved these changes
May 29, 2020
BridgeAR
approved these changes
May 29, 2020
BridgeAR
added
the
author ready
addaleax
approved these changes
May 29, 2020
|
Fixups to an unreleased experimental internal feature... fast track? |
|
Landed in 56e4460 |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 30, 2020
PR-URL: nodejs#33622 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
2 tasks
This was referenced Jun 4, 2020
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
PR-URL: #33622 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #33622 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
toStringTagon EventTarget so that our implmentation logs[object EventTarget], add tests to that and a test for subclassingEvents.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes