Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api: remove napi_env::CallIntoModuleThrow #33570

Closed
wants to merge 3 commits into from
Closed

n-api: remove napi_env::CallIntoModuleThrow #33570

wants to merge 3 commits into from

Commits on May 26, 2020

  1. n-api: remove napi_env::CallIntoModuleThrow 

    Give `napi_env::CallIntoModule` the thrower used by
`CallIntoModuleThrow` as its default second argument. That way we do
not need two different methods on `napi_env` for calling into the
addon.
    Gabriel Schulhof committed May 26, 2020
    Configuration menu
    Copy the full SHA
    129c7ae View commit details
    Browse the repository at this point in the history

  2. restore template argument and remove std::function

    Gabriel Schulhof committed May 26, 2020
    Configuration menu
    Copy the full SHA
    19a518f View commit details
    Browse the repository at this point in the history

  3. derive the type of the throw handler using decltype

    Gabriel Schulhof committed May 26, 2020
    Configuration menu
    Copy the full SHA
    7743f46 View commit details
    Browse the repository at this point in the history