Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: specify maxHeadersCount alias for maxHeaderListPairs #33519

Closed
wants to merge 5 commits into from

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented May 22, 2020

Fixes: #32388

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels May 22, 2020
Copy link
Member

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maxHeadersCount, which have s

@rexagod rexagod requested a review from himself65 May 23, 2020 14:25
@himself65 himself65 changed the title doc: specify maxHeaderCount alias for maxHeaderListPairs doc: specify maxHeadersCount alias for maxHeaderListPairs May 23, 2020
doc/api/http2.md Outdated Show resolved Hide resolved
@himself65 himself65 dismissed their stale review May 24, 2020 10:30

No change requested

@BridgeAR BridgeAR force-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72 Compare May 31, 2020 12:18
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with listing one or both examples. I prefer both, but either way is fine with me. I do think the parentheses around the second example are probably unnecessary?

@rexagod
Copy link
Member Author

rexagod commented Jun 20, 2020

ping @Trott

doc/api/http2.md Outdated Show resolved Hide resolved
@rexagod rexagod requested a review from Trott June 20, 2020 15:15
Copy link
Member

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@himself65 himself65 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 26, 2020
jasnell pushed a commit that referenced this pull request Jun 26, 2020
Fixes: #32388

PR-URL: #33519
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jun 26, 2020

Landed in 074df49

@jasnell jasnell closed this Jun 26, 2020
codebytere pushed a commit that referenced this pull request Jun 27, 2020
Fixes: #32388

PR-URL: #33519
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request Jun 28, 2020
codebytere pushed a commit that referenced this pull request Jun 30, 2020
Fixes: #32388

PR-URL: #33519
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
Fixes: #32388

PR-URL: #33519
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
codebytere pushed a commit that referenced this pull request Jul 12, 2020
Fixes: #32388

PR-URL: #33519
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request Jul 13, 2020
codebytere pushed a commit that referenced this pull request Jul 14, 2020
Fixes: #32388

PR-URL: #33519
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add maxHeadersCount support for http(s)2 server
6 participants