meta: add flaky test issue template #33500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
|
@AshCripps this is topical. I'm working with a group of interns this summer on a project related to accurately and automatically detecting flaky tests in a codebase (CC: @joyeecheung). Would love to see if we could use Node.js as a place to test the methods we're coming up with. I think developing a template for this is a great idea. |
bcoe
reviewed
May 21, 2020
sam-github
reviewed
May 21, 2020
AshCripps
force-pushed
the
add-flaky-test-template
branch
from
37aef5f
to
a42ab32
Compare
|
@bcoe @sam-github Ive addressed your comments, I've tried the details block, it didn't look too great locally but need to see how it looks on GitHub. |
|
@bcoe WDYT? I'd be tempted to leave it out, the tap output is usually not that long. |
BridgeAR
reviewed
May 23, 2020
Add a flaky test issue template to ensure that enough information is provided for investigation
AshCripps
force-pushed
the
add-flaky-test-template
branch
from
a42ab32
to
78f1402
Compare
|
I updated this to remove the details block as it didn't look right IMO and have instead put a |
BridgeAR
approved these changes
May 26, 2020
BridgeAR
added
the
author ready
BethGriggs
approved these changes
May 26, 2020
sam-github
pushed a commit
that referenced
this pull request
May 28, 2020
Add a flaky test issue template to ensure that enough information is provided for investigation PR-URL: #33500 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
|
Landed in fb33b67 |
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
Add a flaky test issue template to ensure that enough information is provided for investigation PR-URL: #33500 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
Add a flaky test issue template to ensure that enough information is provided for investigation PR-URL: #33500 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jul 8, 2020
Add a flaky test issue template to ensure that enough information is provided for investigation PR-URL: #33500 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a flaky test issue template to ensure that enough information is provided for investigation
I think this will be useful especially for newer people interested in helping out the build WG as it requires no access to report flaky tests, and is often an approach we ask people to take to help familarise themselves with our CI/test suite.
Checklist