buffer: don't abort on prototype getters #3302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accessing prototype properties directly on a typed array will throw. So do an extra check in Buffer's own getters to verify it is being called on an instance. Fixes: nodejs#3297
|
LGTM |
1 similar comment
|
LGTM |
trevnorris
added a commit
that referenced
this pull request
Oct 9, 2015
Accessing prototype properties directly on a typed array will throw. So do an extra check in Buffer's own getters to verify it is being called on an instance. Fixes: #3297 PR-URL: #3302 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
|
Thanks. Landed on e97dae5 |
|
Isn't this a major change? Behaviour is not backward compatible, right? Earlier we used to throw and we don't now. |
|
@thefourtheye This was a bug from the change to using typed arrays. |
|
If you take notice of the change, we didn't remove an exception. It was throwing because of bad access to a typed array property. |
|
@trevnorris ... should this land in v4.x? ... nm... looking at it, there's no reason why not :-) |
trevnorris
added a commit
that referenced
this pull request
Oct 10, 2015
Accessing prototype properties directly on a typed array will throw. So do an extra check in Buffer's own getters to verify it is being called on an instance. Fixes: #3297 PR-URL: #3302 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
|
landed in v4.x in 5479562 |
Ah, fine then. Thanks for clarifying :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessing prototype properties directly on a typed array will throw. So
do an extra check in Buffer's own getters to verify it is being called
on an instance.
Fixes: #3297
R=@Fishrock123 ?
CI: https://ci.nodejs.org/job/node-test-pull-request/468/