Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.x] module: backport disable conditional exports, self resolve warnings #32959

Closed
wants to merge 3 commits into from
Closed

[12.x] module: backport disable conditional exports, self resolve warnings #32959

wants to merge 3 commits into from

Conversation

guybedford
Copy link
Contributor

Backport for #31845.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. v12.x labels Apr 21, 2020
@guybedford guybedford mentioned this pull request Apr 21, 2020
Closed
4 tasks
@targos
Copy link
Member

targos commented Apr 21, 2020

Thanks. I realized I forgot to run the test with --experimental-modules 🤦 . With CJS tests it works because the common module re-runs the test if you forget the flags, but with ESM the test fails before the evaluation of common.

@targos
Copy link
Member

targos commented Apr 21, 2020

Landed in ecddf65

@targos targos closed this Apr 21, 2020
targos pushed a commit that referenced this pull request Apr 21, 2020
@guybedford @targos
module: disable conditional exports, self resolve warnings
ecddf65 
PR-URL: #31845
Reviewed-By: Jan Krems <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>

Backport-PR-URL: #32959
Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guybedford @targos @nodejs-github-bot