Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: remove duplicated code #32719

Closed
wants to merge 1 commit into from
Closed

lib: remove duplicated code #32719

wants to merge 1 commit into from

Conversation

himself65
Copy link
Member

@himself65 himself65 commented Apr 8, 2020 •
edited
Loading

node/src/spawn_sync.cc

Lines 1036 to 1045 in d09e1da

Local<String> string;
if (!value->ToString(env()->isolate()->GetCurrentContext())
.ToLocal(&string))
return Nothing<int>();
js_array
->Set(context,
i,
value->ToString(env()->isolate()->GetCurrentContext())
.ToLocalChecked())
.Check();

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem. labels Apr 8, 2020
@himself65
Copy link
Member Author

himself65 commented Apr 8, 2020 •
edited
Loading

BTW, Do we have rules for something like no-unused-vars(ESLint) in C++ linter?

@addaleax
Copy link
Member

addaleax commented Apr 8, 2020

@himself65 I don’t think so, but I think for C++ that might be quite a bit harder to implement than it is for JS, because the constructor/destructor of a variable might be relevant (e.g. HandleScopes might appear like unused variables that way).

However, the compiler will generally emit warnings for unused variables where it can tell that they are useless.

@addaleax
Copy link
Member

addaleax commented Apr 8, 2020

Ah, btw, the commit message should start with src: here.

@himself65
Copy link
Member Author

Ah, btw, the commit message should start with src: here.

oh, I didn't notice that

@himself65 himself65 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 9, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30584/

@himself65 himself65 self-assigned this Apr 11, 2020
himself65 added a commit to himself65/node that referenced this pull request Apr 11, 2020
@himself65
src: remove duplicated code
1c4b205 
PR-URL: nodejs#32719
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@himself65
Copy link
Member Author

Landed in 1c4b205

@himself65 himself65 closed this Apr 11, 2020
@himself65 himself65 deleted the 20200408-fix branch April 11, 2020 06:27
targos pushed a commit that referenced this pull request Apr 12, 2020
@himself65 @targos
src: remove duplicated code
ea17855 
PR-URL: #32719
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
@himself65 @BethGriggs
src: remove duplicated code
fb0c4fa 
PR-URL: #32719
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
@himself65 @targos
src: remove duplicated code
d0d7ebc 
PR-URL: #32719
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@Flarna Flarna Flarna approved these changes

Assignees

@himself65 himself65

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@himself65 @addaleax @nodejs-github-bot @jasnell @cjihrig @gengjiawen @Flarna