test: replace console.log/error() with debuglog #32692
Conversation
himself65
added
the
author ready
|
Should I fix something for the failing checks? |
I don't think you can, as they're not related with your changes. I've run CI build multiple times and, as the result, created #32863 to track a flaky test. @addaleax could you advice how to proceed with this PR, considering that one of tests is constantly failing (yet, it's not related with the PR)? See https://ci.nodejs.org/job/node-test-pull-request/30753/ as an example of build result. |
|
@puzpuzpuz If a test is failing often enough for PRs to become unlandable, we should mark it as flaky, so that we only get a yellow instead of a red CI, which allows PRs to land. Thanks for opening an issue, btw! |
|
@addaleax Looks like we finally have a green build here. But I've noticed your comment on the original issue (#32678 (comment)) and the issue is closed as the consensus was not to go any further with swapping console.log with debug messages in tests. This PR has enough approvals and a green build. But considering objections raised on the original issue, I'm not certain on how we're going to proceed with this PR. WDYT? |
|
@puzpuzpuz I personally think that this kind of PR is not improving the debugging experience for tests, and I also personally think that blocking this PR isn’t really worth it. You can feel free to go ahead and land this, if you like 👍 |
PR-URL: #32692 Fixes: #32678 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
|
Landed in a9da656 Congrats on your first contribution! 🎉 |
PR-URL: #32692 Fixes: #32678 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: nodejs#32692 Fixes: nodejs#32678 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #32692 Fixes: #32678 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #32692 Fixes: #32678 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Use utility debug logs instead of console logs in in
test-domain-http-server.jsFixes: #32678
Checklist
make -j4 test(UNIX)