Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove unused variables on async hook test #32630

Closed
wants to merge 1 commit into from
Closed

test: remove unused variables on async hook test #32630

wants to merge 1 commit into from

Conversation

julianduque
Copy link
Contributor

This commit removes the id and type arguments from the mustCall
function on init.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 3, 2020
@julianduque
test: remove unused variables on async hook test
652a521 
This commit remove the `id` and `type` arguments from the mustCall
function on init.
@julianduque julianduque force-pushed the julianduque/remove-unused-variables-ah-test branch from ad1b8b2 to 652a521 Compare April 3, 2020 23:18
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 5, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30470/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30482/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30490/

@addaleax
Copy link
Member

addaleax commented Apr 6, 2020

Landed in 056e687

@addaleax addaleax closed this Apr 6, 2020
addaleax pushed a commit that referenced this pull request Apr 6, 2020
@julianduque @addaleax
test: remove unused variables on async hook test
056e687 
This commit remove the `id` and `type` arguments from the mustCall
function on init.

PR-URL: #32630
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@julianduque julianduque deleted the julianduque/remove-unused-variables-ah-test branch April 6, 2020 19:11
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@julianduque @BethGriggs
test: remove unused variables on async hook test
aea24b7 
This commit remove the `id` and `type` arguments from the mustCall
function on init.

PR-URL: #32630
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2020
@julianduque @targos
test: remove unused variables on async hook test
6d12242 
This commit remove the `id` and `type` arguments from the mustCall
function on init.

PR-URL: #32630
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@julianduque @targos
test: remove unused variables on async hook test
6feed98 
This commit remove the `id` and `type` arguments from the mustCall
function on init.

PR-URL: #32630
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jvelezpo jvelezpo jvelezpo approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@julianduque @nodejs-github-bot @addaleax @jasnell @jvelezpo @lpinca @targos @cjihrig @tniessen