src: include AsyncWrap provider strings in snapshot #32572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and move them to `IsolateData`, because they should exist once per Isolate.
nodejs-github-bot
added
the
c++
|
CI: https://ci.nodejs.org/job/node-test-pull-request/30270/ (:heavy_check_mark:) |
jasnell
approved these changes
Mar 30, 2020
cjihrig
approved these changes
Mar 31, 2020
addaleax
added
the
author ready
addaleax
added a commit
that referenced
this pull request
Apr 2, 2020
… and move them to `IsolateData`, because they should exist once per Isolate. PR-URL: #32572 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in 2a88515 |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
… and move them to `IsolateData`, because they should exist once per Isolate. PR-URL: #32572 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
removed
the
author ready
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
… and move them to `IsolateData`, because they should exist once per Isolate. PR-URL: nodejs#32572 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
… and move them to `IsolateData`, because they should exist once per Isolate. PR-URL: #32572 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and move them to
IsolateData, because they should exist onceper Isolate.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes