Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: changed functional logic in cluster schedulers #32505

Closed
wants to merge 1 commit into from
Closed

lib: changed functional logic in cluster schedulers #32505

wants to merge 1 commit into from

Conversation

yashLadha
Copy link
Contributor

Free pool in round_robin scheduler is implemented as an array. There
were constant lookups being for distributing load on other workers in
free pool. Reimplementing in Map will create will be more performant as
compared to Array implementation. This was done for all in past but free
wasn't implemented at that time.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the cluster Issues and PRs related to the cluster subsystem. label Mar 26, 2020
@yashLadha yashLadha changed the title lib: changed functional login in cluster schedulers lib: changed functional logic in cluster schedulers Mar 26, 2020
@yashLadha yashLadha force-pushed the refactor/functional_changes_scheduling_handlers branch from ea584c4 to e3e536f Compare March 26, 2020 14:20
@yashLadha yashLadha force-pushed the refactor/functional_changes_scheduling_handlers branch from e3e536f to 7e551a7 Compare March 26, 2020 16:18
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30112/

targos
targos reviewed Mar 27, 2020
View reviewed changes
lib/internal/cluster/round_robin_handle.js Outdated Show resolved Hide resolved
lib/internal/cluster/round_robin_handle.js Outdated Show resolved Hide resolved
@yashLadha yashLadha force-pushed the refactor/functional_changes_scheduling_handlers branch from 7e551a7 to 00f3d5e Compare March 27, 2020 09:43
@yashLadha yashLadha force-pushed the refactor/functional_changes_scheduling_handlers branch from 00f3d5e to 3791aba Compare March 27, 2020 10:16
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 2, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30403/

@yashLadha
lib: changed functional logic in cluster schedulers
e8f1115 
Free pool in round_robin scheduler is implemented as an array. There
were constant lookups being for distributing load on other workers in
free pool. Reimplementing in Map will create will be more performant as
compared to Array implementation. This was done for all in past but free
wasn't implemented at that time.
@yashLadha yashLadha force-pushed the refactor/functional_changes_scheduling_handlers branch from 3791aba to e8f1115 Compare April 4, 2020 15:30
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30457/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30521/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30528/

@yashLadha
Copy link
Contributor Author

yashLadha commented Apr 7, 2020 •
edited
Loading

Latest CI passed but still there are failure jobs marked? 😕

@addaleax
Copy link
Member

addaleax commented Apr 7, 2020

Latest CI passed but still there are failure jobs marked? confused

Yeah, that’s a oddity with the way that the github bot reports results back to github from Jenkins. The Jenkins status is what counts here, so this is all good 👍

@addaleax
Copy link
Member

addaleax commented Apr 7, 2020

Landed in 6faa162

addaleax pushed a commit that referenced this pull request Apr 7, 2020
@yashLadha @addaleax
lib: changed functional logic in cluster schedulers
6faa162 
Free pool in round_robin scheduler is implemented as an array. There
were constant lookups being for distributing load on other workers in
free pool. Reimplementing in Map will create will be more performant as
compared to Array implementation. This was done for all in past but free
wasn't implemented at that time.

PR-URL: #32505
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@addaleax addaleax closed this Apr 7, 2020
targos pushed a commit that referenced this pull request Apr 12, 2020
@yashLadha @targos
lib: changed functional logic in cluster schedulers
94251c4 
Free pool in round_robin scheduler is implemented as an array. There
were constant lookups being for distributing load on other workers in
free pool. Reimplementing in Map will create will be more performant as
compared to Array implementation. This was done for all in past but free
wasn't implemented at that time.

PR-URL: #32505
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
@yashLadha @BethGriggs
lib: changed functional logic in cluster schedulers
ce79923 
Free pool in round_robin scheduler is implemented as an array. There
were constant lookups being for distributing load on other workers in
free pool. Reimplementing in Map will create will be more performant as
compared to Array implementation. This was done for all in past but free
wasn't implemented at that time.

PR-URL: #32505
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
@yashLadha @targos
lib: changed functional logic in cluster schedulers
7dd001c 
Free pool in round_robin scheduler is implemented as an array. There
were constant lookups being for distributing load on other workers in
free pool. Reimplementing in Map will create will be more performant as
compared to Array implementation. This was done for all in past but free
wasn't implemented at that time.

PR-URL: #32505
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mscdex mscdex mscdex left review comments

@trivikr trivikr trivikr approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@targos targos targos approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. cluster Issues and PRs related to the cluster subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@yashLadha @nodejs-github-bot @addaleax @mscdex @jasnell @targos @gireeshpunathil @trivikr