net: wait for shutdown to complete before closing #32491
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When not allowing half open, handle.close would be invoked before shutdown has been called and completed causing a potential data race. Fixes: nodejs#32486 (comment)
ronag
added
wip
|
This is WIP I'm expecting it to fail in CI on win10 (#32487) |
addaleax
approved these changes
Mar 25, 2020
|
CI: https://ci.nodejs.org/job/node-test-pull-request/30072/ (:yellow_heart:) |
ronag
commented
Mar 25, 2020
| @@ -65,9 +65,7 @@ function onexit() { | |||
| { type: 'TCPCONNECTWRAP', | |||
| id: 'tcpconnect:1', triggerAsyncId: 'tcp:1' }, | |||
| { type: 'TCPWRAP', id: 'tcp:2', triggerAsyncId: 'tcpserver:1' }, | |||
| { type: 'TLSWRAP', id: 'tls:2', triggerAsyncId: 'tcpserver:1' }, | |||
| { type: 'Immediate', id: 'immediate:1', triggerAsyncId: 'tcp:2' }, | |||
| { type: 'Immediate', id: 'immediate:2', triggerAsyncId: 'tcp:1' }, | |||
There was a problem hiding this comment.
The order of Immediate here is platform dependent...
|
@addaleax PTAL, I've applied the required win10 fix. I think this should be able to land as a patch? |
addaleax
approved these changes
Mar 25, 2020
ronag
added
the
author ready
lpinca
approved these changes
Mar 29, 2020
|
I don't understand why the |
|
Landed in 138eb32 |
ronag
added a commit
that referenced
this pull request
Apr 1, 2020
When not allowing half open, handle.close would be invoked before shutdown has been called and completed causing a potential data race. Fixes: #32486 (comment) PR-URL: #32491 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
When not allowing half open, handle.close would be invoked before shutdown has been called and completed causing a potential data race. Fixes: #32486 (comment) PR-URL: #32491 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
When not allowing half open, handle.close would be invoked before shutdown has been called and completed causing a potential data race. Fixes: #32486 (comment) PR-URL: #32491 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
When not allowing half open, handle.close would be invoked before shutdown has been called and completed causing a potential data race. Fixes: #32486 (comment) PR-URL: #32491 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When not allowing half open, handle.close would be
invoked before shutdown has been called and
completed causing a potential data race.
Fixes: #32486 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes