Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: refactoring and cleanup of node_i18n #32438

Closed
wants to merge 1 commit into from
Closed

src: refactoring and cleanup of node_i18n #32438

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Mar 23, 2020 •
edited
Loading

Starting some cleanup/refactoring of node_i18n

  • Refactor Converter and ConverterObject definitions
    • Move definitions to node_i18n.h
    • Introduce a new utility functions for better encapsulation
    • Adhere closer to c++ style guide
    • Simplify some state tracking
    • Use std::unique_ptr for cleanup
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 23, 2020
@jasnell jasnell requested review from joyeecheung and addaleax March 23, 2020 18:50
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29995/

@joyeecheung
Copy link
Member

joyeecheung commented Mar 24, 2020 •
edited
Loading

Can you add some high-level description in the OP or the commit message? I can see that there are some helper class added and class definition separated but not sure if they are meant to be copied verbatim or is there something else intended

@jasnell
Copy link
Member Author

jasnell commented Mar 24, 2020

@joyeecheung:

Can you add some high-level description in the OP or the commit message

Done :-)

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30142/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30172/

addaleax
addaleax approved these changes Mar 29, 2020
View reviewed changes
src/node_i18n.cc Outdated Show resolved Hide resolved
src/node_i18n.cc Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30179/

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 29, 2020
joyeecheung
joyeecheung approved these changes Mar 30, 2020
View reviewed changes
src/node_i18n.h Show resolved Hide resolved
jasnell added a commit that referenced this pull request Mar 30, 2020
@jasnell
src: refactoring and cleanup of node_i18n
accc984 
Signed-off-by: James M Snell <[email protected]>

PR-URL: #32438
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@jasnell
Copy link
Member Author

jasnell commented Mar 30, 2020

Landed in accc984

@jasnell jasnell closed this Mar 30, 2020
MylesBorins pushed a commit that referenced this pull request Mar 31, 2020
@jasnell @MylesBorins
src: refactoring and cleanup of node_i18n
5080491 
Signed-off-by: James M Snell <[email protected]>

PR-URL: #32438
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
Merged
@targos targos added backport-blocked-v12.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v12.x labels Apr 22, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@jasnell @targos
src: refactoring and cleanup of node_i18n
4f9ff92 
Signed-off-by: James M Snell <[email protected]>

PR-URL: nodejs#32438
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
@jasnell @targos
src: refactoring and cleanup of node_i18n
e035194 
Signed-off-by: James M Snell <[email protected]>

PR-URL: #32438
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@targos targos mentioned this pull request May 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jasnell @nodejs-github-bot @joyeecheung @addaleax @targos