net: don't explicitly set readable/writable #32271
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
net.Socket
is slightly breaking stream invariants by having readable/writable going fromfalse
totrue
. Streams assume that readable/writable starts outtrue
and then goes tofalse
throughpush(null)
/end()
after which it never goes back totrue
, e.g. once a stream iswritable == false
it is assumed it will never becometrue
.This PR changes 2 things:
Unless explicitly set to
false
through options:readable
/writable
true
by default.push(null)
/end()
to setreadable
/writable
tofalse
. Note that this would cause the socket to emit the'end'
/'finish'
events, which it did not do previously.In the case it is explicitly set to
false
throughoptions
it is assumed to never becometrue
.This makes
net
behave like regular streams and the way quic currently handles the corresponding functionality.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes