async_hooks: fix context loss after nested calls to AsyncLocalStorage #32085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
async_hooks
puzpuzpuz
force-pushed
the
async-local-storage-fix-nested-calls
branch
from
3caff2f to
4c28a3d
Compare
2 tasks
Qard
approved these changes
Mar 5, 2020
vdeturckheim
reviewed
Mar 5, 2020
vdeturckheim
approved these changes
Mar 5, 2020
|
@puzpuzpuz I am afraid there is a curse on your PRs and CI 😝. I will resume this build 😉 |
I knew it. Sounds like the most logical reason for these permanently flaky builds. 🤣 Thanks for restarting it. |
|
Looks like the second attempt was successful. 🥳 |
Qard
added
the
author ready
mhdawson
pushed a commit
that referenced
this pull request
Mar 6, 2020
PR-URL: #32085 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
|
Landed in 86ab4ee |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2020
PR-URL: #32085 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
|
Blocked on #26540. |
4 tasks
|
v12 backport: #32318 |
puzpuzpuz
added a commit
to puzpuzpuz/node
that referenced
this pull request
Apr 14, 2020
PR-URL: nodejs#32085 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
targos
removed
the
author ready
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
PR-URL: nodejs#32085 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32085 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following issues within
AsyncLocalStorageAPI:run*were erasing the outer store, leading to context loss.test-async-local-storage-nested.jswas updated to validate this fix, as its previous contents were a partial duplicate oftest-async-local-storage-no-mix-contexts.jsexit*were switchingenabledfield totruewithout checking current value. This leads to incorrect behavior of furthergetStoreandrun*calls.These issues were discussed in #31950, but as that PR involves significant changes in implementation and will require some time to settle down.
cc @vdeturckheim @Qard @Flarna
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes