build: add asan check in Github action #31902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
|
Seems like a good idea but how long does |
https://github.com/nodejs/node/pull/31902/checks?check_run_id=460428978 took 1 hr 40mins. |
|
ASAN checks failed on first error (https://github.com/nodejs/node/runs/460428978?check_suite_focus=true), so I add |
|
@bnoordhuis @addaleax @richardlau Can you review this ? thanks. |
bnoordhuis
approved these changes
Feb 25, 2020
gengjiawen
added
the
author ready
gengjiawen
added a commit
that referenced
this pull request
Mar 3, 2020
PR-URL: #31902 Reviewed-By: Ben Noordhuis <[email protected]>
|
Landed in 3ec4b21 |
2 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Mar 4, 2020
PR-URL: #31902 Reviewed-By: Ben Noordhuis <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 16, 2020
PR-URL: #31902 Reviewed-By: Ben Noordhuis <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
PR-URL: #31902 Reviewed-By: Ben Noordhuis <[email protected]>
Merged
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This related to #30257
This currently only runs on linux only. Acutally windows has made some progress on
this too, see https://devblogs.microsoft.com/cppblog/addresssanitizer-asan-for-windows-with-msvc/, but it require cmake as build toolchain IIUC. Also current code asan checks broken on macOS, so I didn't add them.
currrent Docker Image source: https://github.com/gengjiawen/node-build/blob/master/Dockerfile.
todo
Hopefully we can remove
continue-on-errorin the future.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes