Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.x] test: Mark test-http2-client-upload as flaky on 10.x #31887

Closed
wants to merge 2 commits into from
Closed

[10.x] test: Mark test-http2-client-upload as flaky on 10.x #31887

wants to merge 2 commits into from

Conversation

AshCripps
Copy link
Member

This test is failing ci a lot and is already marked as flaky on master and 12.x

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v10.x labels Feb 20, 2020
@AshCripps AshCripps changed the title [10.x] Mark test-http2-client-upload as flaky on 10.x [10.x] test: Mark test-http2-client-upload as flaky on 10.x Feb 20, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29252/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29253/

richardlau
richardlau approved these changes Feb 20, 2020
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking nit: move the new entry to the top of the section so the listed tests are in alphabetical order.

@AshCripps AshCripps force-pushed the make-10.x-http-tests-flaky branch from 978f705 to c98d964 Compare February 20, 2020 17:12
test: mark test-http2-client-upload as flaky on 10.x
3a54d73 
This test is already marked as flaky on 12.x and master
@AshCripps AshCripps force-pushed the make-10.x-http-tests-flaky branch from c98d964 to 3a54d73 Compare February 20, 2020 17:13
@BethGriggs
Copy link
Member

I've cherry-picked #27277 on to the staging branch, hopefully that'll help us get stable CI's.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29314/

test: add more flaky tests
3268fed 
These tests are also flaky on v10.x
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 24, 2020 •
edited by BethGriggs
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/29315/ ✅ 🎉

@BethGriggs BethGriggs mentioned this pull request Feb 24, 2020
Closed
4 tasks
BethGriggs pushed a commit that referenced this pull request Feb 24, 2020
@BethGriggs
test: mark http2 tests as flaky on 10.x
a8fd8a1 
These tests are already marked as flaky on 12.x and master.

PR-URL: #31887
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@BethGriggs
Copy link
Member

Landed in a8fd8a1

@BethGriggs BethGriggs closed this Feb 24, 2020
@AshCripps AshCripps deleted the make-10.x-http-tests-flaky branch February 25, 2020 13:28
@BethGriggs BethGriggs mentioned this pull request Mar 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AshCripps @nodejs-github-bot @BethGriggs @richardlau