doc: add entry for AsyncHook class
#31865
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
async_hooks
addaleax
reviewed
Feb 19, 2020
addaleax
reviewed
Feb 20, 2020
doc/api/async_hooks.md
Outdated
|
|
||
| The class `AsyncHook` exposes interface for tracking lifetime events | ||
| of asynchronous operations. Using a unique ID per asynchronous call, | ||
| it helps associating method calls that otherwise do not appear together |
There was a problem hiding this comment.
Either
Suggested change
| it helps associating method calls that otherwise do not appear together | |
| it helps with associating method calls that otherwise do not appear together |
or
Suggested change
| it helps associating method calls that otherwise do not appear together | |
| it helps associate method calls that otherwise do not appear together |
That being said – what’s a typical call stack?
There was a problem hiding this comment.
@addaleax , I used typical here to mean a representative call stack on node.js program error. As per my understanding, a representative stack is a incomplete part of an asynchronous sequence. Am I wrong?
There was a problem hiding this comment.
@HarshithaKP I’m still confused… That kind of only moves the question from “what’s a typical call stack?” to “what’s a representative call stack?”.
To be honest, I think it’s okay to drop the second sentence here. The sentence is not accurate anyway, the IDs are unique per asynchronous resource but not per asynchronous call.
There was a problem hiding this comment.
@addaleax, dropped the second sentence.
|
@nodejs/documentation (I'm feeling @vsemozhetbyt's absence these days. ❤️) |
HarshithaKP
force-pushed
the
asyc_hook_class_name
branch
from
90da144 to
410b6e6
Compare
Qard
approved these changes
Feb 25, 2020
gireeshpunathil
added
the
author ready
addaleax
removed
the
author ready
addaleax
approved these changes
Mar 9, 2020
BridgeAR
approved these changes
Mar 9, 2020
BridgeAR
added
the
author ready
Qard
approved these changes
Mar 10, 2020
jasnell
approved these changes
Mar 10, 2020
addaleax
pushed a commit
that referenced
this pull request
Mar 11, 2020
fixes: #31661 PR-URL: #31865 Fixes: #31661 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in e4a72d6 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 11, 2020
fixes: #31661 PR-URL: #31865 Fixes: #31661 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
fixes: #31661 PR-URL: #31865 Fixes: #31661 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #31661
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes