Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc,assert: rename "mode" to "assertion mode" #31635

Closed
wants to merge 0 commits into from
Closed

doc,assert: rename "mode" to "assertion mode" #31635

wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 4, 2020

Rename "strict mode" in the assert module to "strict assertion mode".
This is to avoid confusion with the more typical meaning of "strict
mode" in ECMAScript.

This necessitates a corresponding change of "legacy mode" to "legacy
assertion mode".

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Feb 4, 2020
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 4, 2020
@Trott
Copy link
Member Author

Trott commented Feb 5, 2020

/ping @BridgeAR

Trott added a commit that referenced this pull request Feb 6, 2020
@Trott
doc,assert: rename "mode" to "assertion mode"
a9e2626 
Rename "strict mode" in the assert module to "strict assertion mode".
This is to avoid confusion with the more typical meaning of "strict
mode" in ECMAScript.

This necessitates a corresponding change of "legacy mode" to "legacy
assertion mode".

PR-URL: #31635
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@Trott
Copy link
Member Author

Trott commented Feb 6, 2020

Landed in a9e2626

@Trott Trott closed this Feb 6, 2020
@Trott Trott force-pushed the strict-assertion-mode branch from 60e105a to a9e2626 Compare February 6, 2020 20:03
@Trott Trott deleted the strict-assertion-mode branch February 6, 2020 20:03
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@Trott @codebytere
doc,assert: rename "mode" to "assertion mode"
6874dee 
Rename "strict mode" in the assert module to "strict assertion mode".
This is to avoid confusion with the more typical meaning of "strict
mode" in ECMAScript.

This necessitates a corresponding change of "legacy mode" to "legacy
assertion mode".

PR-URL: #31635
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@Trott @codebytere
doc,assert: rename "mode" to "assertion mode"
71c1858 
Rename "strict mode" in the assert module to "strict assertion mode".
This is to avoid confusion with the more typical meaning of "strict
mode" in ECMAScript.

This necessitates a corresponding change of "legacy mode" to "legacy
assertion mode".

PR-URL: #31635
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@Trott @codebytere
doc,assert: rename "mode" to "assertion mode"
b4d81b9 
Rename "strict mode" in the assert module to "strict assertion mode".
This is to avoid confusion with the more typical meaning of "strict
mode" in ECMAScript.

This necessitates a corresponding change of "legacy mode" to "legacy
assertion mode".

PR-URL: #31635
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@Trott @codebytere
doc,assert: rename "mode" to "assertion mode"
8f75c74 
Rename "strict mode" in the assert module to "strict assertion mode".
This is to avoid confusion with the more typical meaning of "strict
mode" in ECMAScript.

This necessitates a corresponding change of "legacy mode" to "legacy
assertion mode".

PR-URL: #31635
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @jasnell @addaleax @lpinca @cjihrig @BridgeAR @nodejs-github-bot