test: mark additional tests as flaky on Windows #31606
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically, any of the tests that failed in the runs for nodejs#31602 which was not already marked as flaky.
addaleax
added
the
flaky-test
nodejs-github-bot
added
async_hooks
|
Please 👍 this comment to approve fast-tracking, CI isn’t in a great state right now and this would make the number of failures a bit easier to deal with. |
richardlau
approved these changes
Feb 1, 2020
joyeecheung
approved these changes
Feb 1, 2020
addaleax
added a commit
that referenced
this pull request
Feb 1, 2020
Basically, any of the tests that failed in the runs for #31602 which was not already marked as flaky. PR-URL: #31606 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
|
Landed in 9528f95, thanks for the reviews! |
codebytere
pushed a commit
that referenced
this pull request
Feb 17, 2020
Basically, any of the tests that failed in the runs for #31602 which was not already marked as flaky. PR-URL: #31606 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 15, 2020
Basically, any of the tests that failed in the runs for #31602 which was not already marked as flaky. PR-URL: #31606 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
Basically, any of the tests that failed in the runs for #31602 which was not already marked as flaky. PR-URL: #31606 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 30, 2020
Basically, any of the tests that failed in the runs for #31602 which was not already marked as flaky. PR-URL: #31606 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, any of the tests that failed in the runs for
#31602 which was not already
marked as flaky.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes