Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: simply test-https-simple.js #31584

Closed
wants to merge 1 commit into from
Closed

test: simply test-https-simple.js #31584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 16 additions & 43 deletions test/parallel/test-https-simple.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,6 @@ const options = {
cert: fixtures.readKey('agent1-cert.pem')
};

const tests = 2;
let successful = 0;

const testSucceeded = () => {
successful = successful + 1;
if (successful === tests) {
server.close();
}
};

const body = 'hello world\n';

const serverCallback = common.mustCall(function(req, res) {
Expand All @@ -57,61 +47,44 @@ const serverCallback = common.mustCall(function(req, res) {
const server = https.createServer(options, serverCallback);

server.listen(0, common.mustCall(() => {
let tests = 0;

function done() {
if (--tests === 0)
server.close();
}

// Do a request ignoring the unauthorized server certs
const port = server.address().port;

const noCertCheckOptions = {
const options = {
hostname: '127.0.0.1',
port: port,
path: '/',
method: 'GET',
rejectUnauthorized: false
};

noCertCheckOptions.Agent = new https.Agent(noCertCheckOptions);

const req = https.request(noCertCheckOptions, common.mustCall((res) => {
tests++;
const req = https.request(options, common.mustCall((res) => {
let responseBody = '';
res.on('data', function(d) {
responseBody = responseBody + d;
});

res.on('end', common.mustCall(() => {
assert.strictEqual(responseBody, body);
testSucceeded();
done();
}));
}));
req.end();

req.on('error', function(e) {
throw e;
});

// Do a request that throws error due to the invalid server certs
const checkCertOptions = {
hostname: '127.0.0.1',
port: port,
path: '/',
method: 'GET'
};

const checkCertReq = https.request(checkCertOptions, function(res) {
res.on('data', function() {
throw new Error('data should not be received');
});

res.on('end', function() {
throw new Error('connection should not be established');
});
});
checkCertReq.end();
// Do a request that errors due to the invalid server certs
options.rejectUnauthorized = true;
tests++;
const checkCertReq = https.request(options, common.mustNotCall()).end();

checkCertReq.on('error', common.mustCall((e) => {
assert.strictEqual(e.code, 'UNABLE_TO_VERIFY_LEAF_SIGNATURE');
testSucceeded();
done();
}));
}));

process.on('exit', function() {
assert.strictEqual(successful, tests);
});