Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update job reference in COLLABORATOR_GUIDE.md #31557

Closed
wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

https://ci.nodejs.org/job/node-test-commit-custom-suites/ is disabled
in Jenkins with a note to instead use
https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/.
Update the guide to remove the layer of indirection.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 28, 2020
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member

Trott commented Jan 31, 2020

Landed in d4c81be

@Trott Trott closed this Jan 31, 2020
Trott pushed a commit that referenced this pull request Jan 31, 2020
https://ci.nodejs.org/job/node-test-commit-custom-suites/ is disabled
in Jenkins with a note to instead use
https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/.
Update the guide to remove the layer of indirection.

PR-URL: #31557
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this pull request Feb 17, 2020
https://ci.nodejs.org/job/node-test-commit-custom-suites/ is disabled
in Jenkins with a note to instead use
https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/.
Update the guide to remove the layer of indirection.

PR-URL: #31557
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Feb 17, 2020
codebytere pushed a commit that referenced this pull request Mar 15, 2020
https://ci.nodejs.org/job/node-test-commit-custom-suites/ is disabled
in Jenkins with a note to instead use
https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/.
Update the guide to remove the layer of indirection.

PR-URL: #31557
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
https://ci.nodejs.org/job/node-test-commit-custom-suites/ is disabled
in Jenkins with a note to instead use
https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/.
Update the guide to remove the layer of indirection.

PR-URL: #31557
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
codebytere pushed a commit that referenced this pull request Mar 30, 2020
https://ci.nodejs.org/job/node-test-commit-custom-suites/ is disabled
in Jenkins with a note to instead use
https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/.
Update the guide to remove the layer of indirection.

PR-URL: #31557
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants