fs: recursion should bail on permission error #31505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
When creating directories recursively, the logic should bail immediately on UV_EACCES and bubble the error to the user. Fixes: nodejs#31481
addaleax
approved these changes
Jan 25, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
addaleax
approved these changes
Jan 25, 2020
Trott
approved these changes
Jan 26, 2020
bcoe
added
the
author ready
|
Landed in f284290 |
Trott
pushed a commit
that referenced
this pull request
Jan 27, 2020
When creating directories recursively, the logic should bail immediately on UV_EACCES and bubble the error to the user. PR-URL: #31505 Fixes: #31481 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
4 tasks
codebytere
pushed a commit
that referenced
this pull request
Feb 17, 2020
When creating directories recursively, the logic should bail immediately on UV_EACCES and bubble the error to the user. PR-URL: #31505 Fixes: #31481 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 15, 2020
When creating directories recursively, the logic should bail immediately on UV_EACCES and bubble the error to the user. PR-URL: #31505 Fixes: #31481 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
When creating directories recursively, the logic should bail immediately on UV_EACCES and bubble the error to the user. PR-URL: #31505 Fixes: #31481 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 30, 2020
When creating directories recursively, the logic should bail immediately on UV_EACCES and bubble the error to the user. PR-URL: #31505 Fixes: #31481 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating directories recursively, the logic should bail immediately on UV_EACCES and bubble the error to the user.
Fixes: #31481
CC: @isaacs
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes