Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maintaining-V8.md #31503

Closed
wants to merge 2 commits into from
Closed

Update maintaining-V8.md #31503

wants to merge 2 commits into from

Conversation

kzs0
Copy link
Contributor

@kzs0 kzs0 commented Jan 25, 2020

Updated to conform to style guide.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Updated to conform to style guide.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 25, 2020
@kzs0 kzs0 requested a review from watilde January 25, 2020 21:36
@Trott
Copy link
Member

Trott commented Jan 26, 2020

Updated to conform to style guide.

We don't specify how to do capitalization in headers in the style guide, do we?

@kzs0
Copy link
Contributor Author

kzs0 commented Jan 26, 2020

No I suppose not, but this would keep the file internally consistent in its capitalization.

@Trott
Copy link
Member

Trott commented Jan 26, 2020

keep the file internally consistent in its capitalization

In that case, can you update line 320 as well?

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 27, 2020
@addaleax
Copy link
Member

Landed in 3d456b1 🎉

@addaleax addaleax closed this Jan 28, 2020
addaleax pushed a commit that referenced this pull request Jan 28, 2020
Updated to conform to style guide.

PR-URL: #31503
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
codebytere pushed a commit that referenced this pull request Feb 17, 2020
Updated to conform to style guide.

PR-URL: #31503
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@codebytere codebytere mentioned this pull request Feb 17, 2020
codebytere pushed a commit that referenced this pull request Mar 16, 2020
Updated to conform to style guide.

PR-URL: #31503
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
Updated to conform to style guide.

PR-URL: #31503
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
codebytere pushed a commit that referenced this pull request Mar 23, 2020
Updated to conform to style guide.

PR-URL: #31503
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 30, 2020
Updated to conform to style guide.

PR-URL: #31503
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants