Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: enable visual code indication in headers #31493

Merged
merged 1 commit into from
Jan 26, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 24, 2020

This enables the grey background for inline code in headers.

Refs: #31460 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 24, 2020
@richardlau
Copy link
Member

“indicatino”? 😁

@Trott
Copy link
Member Author

Trott commented Jan 24, 2020

Some screenshots:

Screen Shot 2020-01-24 at 5 06 16 AM


Screen Shot 2020-01-24 at 5 06 25 AM


Screen Shot 2020-01-24 at 5 06 48 AM


Screen Shot 2020-01-24 at 5 07 05 AM


Screen Shot 2020-01-24 at 5 07 23 AM

@Trott
Copy link
Member Author

Trott commented Jan 24, 2020

“indicatino”? 😁

Commit message fixed. Thanks!

@Trott Trott changed the title doc: enable visual code indicatino in headers doc: enable visual code indication in headers Jan 24, 2020
Copy link
Member

@GeoffreyBooth GeoffreyBooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't also want to make the code text monospaced?

@Trott
Copy link
Member Author

Trott commented Jan 24, 2020

We don't also want to make the code text monospaced?

Yes, next PR if someone else doesn't beat me to it. I'm doing one self-contained small change at a time because nothing terrifies me more than CSS.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 24, 2020
@@ -33,7 +33,6 @@ h3, h3 code,
h4, h4 code,
h5, h5 code,
h6, h6 code {
background-color: inherit;
color: inherit;
font-family: inherit;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
font-family: inherit;

Just delete this line and it should use the monospaced font.

@XhmikosR
Copy link
Contributor

I'd say first move with #31492

@XhmikosR
Copy link
Contributor

The we'd just need to remove 2 properties from one selector without having to worry about breaking other stuff :)

This enables the grey background for inline code in headers.

Refs: nodejs#31460 (comment)

PR-URL: nodejs#31493
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott Trott merged commit 97ac661 into nodejs:master Jan 26, 2020
@Trott
Copy link
Member Author

Trott commented Jan 26, 2020

Landed in 97ac661

@Trott Trott deleted the code-in-headers branch January 26, 2020 16:09
codebytere pushed a commit that referenced this pull request Feb 17, 2020
This enables the grey background for inline code in headers.

Refs: #31460 (comment)

PR-URL: #31493
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request Feb 17, 2020
codebytere pushed a commit that referenced this pull request Mar 15, 2020
This enables the grey background for inline code in headers.

Refs: #31460 (comment)

PR-URL: #31493
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
This enables the grey background for inline code in headers.

Refs: #31460 (comment)

PR-URL: #31493
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants