benchmark: fix getStringWidth() benchmark #31476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
benchmark
|
Chalk one up for the benchmark tests! They legitimately found a broken benchmark this time. |
|
I'd like to fast-track this to fix node-daily-master. Collaborators, 👍 here to approve. |
addaleax
approved these changes
Jan 23, 2020
|
Benchmark CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/11740/ (queued) |
Trott
added
the
author ready
cjihrig
approved these changes
Jan 23, 2020
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 23, 2020
8fb5fe2 broke the benchmark for getStringWidth(). This fixes it up by updating the argument to `require()` to retrieve `getStringWidth()` from the new internal module location. PR-URL: nodejs#31476 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in 085a5c7 |
codebytere
pushed a commit
that referenced
this pull request
Feb 17, 2020
8fb5fe2 broke the benchmark for getStringWidth(). This fixes it up by updating the argument to `require()` to retrieve `getStringWidth()` from the new internal module location. PR-URL: #31476 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 15, 2020
8fb5fe2 broke the benchmark for getStringWidth(). This fixes it up by updating the argument to `require()` to retrieve `getStringWidth()` from the new internal module location. PR-URL: #31476 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
8fb5fe2 broke the benchmark for getStringWidth(). This fixes it up by updating the argument to `require()` to retrieve `getStringWidth()` from the new internal module location. PR-URL: #31476 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8fb5fe2 broke the benchmark for
getStringWidth(). This fixes it up by updating the argument to
require()to retrievegetStringWidth()from the new internal modulelocation.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes