Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve wasi stat test #31413

Closed
wants to merge 1 commit into from
Closed

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 19, 2020

This commit improved the stat test a bit by verifying that
S_ISDIR() works properly. It also adds missing coverage for
__wasi_path_remove_directory().

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

This commit improved the stat test a bit by verifying that
S_ISDIR() works properly. It also adds missing coverage for
__wasi_path_remove_directory().
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 19, 2020
@nodejs-github-bot
Copy link
Collaborator

@lundibundi lundibundi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 20, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 20, 2020

@Trott
Copy link
Member

Trott commented Jan 21, 2020

Landed in da66054

@Trott Trott closed this Jan 21, 2020
Trott pushed a commit that referenced this pull request Jan 21, 2020
This commit improved the stat test a bit by verifying that
S_ISDIR() works properly. It also adds missing coverage for
__wasi_path_remove_directory().

PR-URL: #31413
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@cjihrig cjihrig deleted the wasi-rmdir branch January 22, 2020 00:42
codebytere pushed a commit that referenced this pull request Feb 17, 2020
This commit improved the stat test a bit by verifying that
S_ISDIR() works properly. It also adds missing coverage for
__wasi_path_remove_directory().

PR-URL: #31413
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Feb 17, 2020
codebytere pushed a commit that referenced this pull request Mar 14, 2020
This commit improved the stat test a bit by verifying that
S_ISDIR() works properly. It also adds missing coverage for
__wasi_path_remove_directory().

PR-URL: #31413
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
This commit improved the stat test a bit by verifying that
S_ISDIR() works properly. It also adds missing coverage for
__wasi_path_remove_directory().

PR-URL: #31413
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants