test: add wasi test for symlink() and readlink() #31403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengjiawen
reviewed
Jan 18, 2020
gengjiawen
approved these changes
Jan 18, 2020
devnexen
approved these changes
Jan 18, 2020
cjihrig
force-pushed
the
wasi-symlinks
branch
from
fdcb0ec to
62c945f
Compare
|
CI is yellow with the exception of the things related to the failing |
cjihrig
added
the
author ready
Trott
approved these changes
Jan 20, 2020
I marked the failing node as offline, notified rvagg, and resumed your CI job.... 🤞 |
|
Now it looks like everything is passing, but the Java post processing is failing.
20:06:27 FATAL: Remote call on JNLP4-connect connection from 203.217.18.114/203.217.18.114:41002 failed
20:06:27 Also: hudson.remoting.Channel$CallSiteStackTrace: Remote call to JNLP4-connect connection from 203.217.18.114/203.217.18.114:41002
20:06:27 at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)
20:06:27 at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)
20:06:27 at hudson.remoting.Channel.call(Channel.java:955)
20:06:27 at hudson.Launcher$RemoteLauncher.kill(Launcher.java:1086)
20:06:27 at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:510)
20:06:27 at hudson.model.Run.execute(Run.java:1853)
20:06:27 at hudson.matrix.MatrixRun.run(MatrixRun.java:153)
20:06:27 at hudson.model.ResourceController.execute(ResourceController.java:97)
20:06:27 at hudson.model.Executor.run(Executor.java:427)
20:06:27 java.lang.NoClassDefFoundError: Could not initialize class hudson.slaves.SlaveComputer
20:06:27 at hudson.util.ProcessTree.get(ProcessTree.java:432)
20:06:27 at hudson.Launcher$RemoteLauncher$KillTask.call(Launcher.java:1103)
20:06:27 at hudson.Launcher$RemoteLauncher$KillTask.call(Launcher.java:1094)
20:06:27 at hudson.remoting.UserRequest.perform(UserRequest.java:212)
20:06:27 at hudson.remoting.UserRequest.perform(UserRequest.java:54)
20:06:27 at hudson.remoting.Request$2.run(Request.java:369)
20:06:27 at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
20:06:27 at java.util.concurrent.FutureTask.run(FutureTask.java:266)
20:06:27 at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
20:06:27 at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
20:06:27 at hudson.remoting.Engine$1.lambda$newThread$0(Engine.java:93)
20:06:27 at java.lang.Thread.run(Thread.java:748)
20:06:27 Caused: java.io.IOException: Remote call on JNLP4-connect connection from 203.217.18.114/203.217.18.114:41002 failed
20:06:27 at hudson.remoting.Channel.call(Channel.java:961)
20:06:27 at hudson.Launcher$RemoteLauncher.kill(Launcher.java:1086)
20:06:27 at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:510)
20:06:27 at hudson.model.Run.execute(Run.java:1853)
20:06:27 at hudson.matrix.MatrixRun.run(MatrixRun.java:153)
20:06:27 at hudson.model.ResourceController.execute(ResourceController.java:97)
20:06:27 at hudson.model.Executor.run(Executor.java:427)
20:06:27 [Text Finder] Looking for pattern '^not ok' in the files at '*.tap'
|
Marked more hosts offline... 😞 |
This test provides missing coverage for __wasi_path_symlink() and __wasi_path_readlink(). PR-URL: nodejs#31403 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]>
cjihrig
force-pushed
the
wasi-symlinks
branch
from
62c945f to
4f11fb6
Compare
codebytere
pushed a commit
that referenced
this pull request
Feb 17, 2020
This test provides missing coverage for __wasi_path_symlink() and __wasi_path_readlink(). PR-URL: #31403 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 14, 2020
This test provides missing coverage for __wasi_path_symlink() and __wasi_path_readlink(). PR-URL: #31403 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
This test provides missing coverage for __wasi_path_symlink() and __wasi_path_readlink(). PR-URL: #31403 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test provides missing coverage for
__wasi_path_symlink()and__wasi_path_readlink().Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes