Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fixup changelog for v10.18.1 #31358

Closed
wants to merge 1 commit into from

Conversation

andrewhughes101
Copy link
Contributor

fixup the changelog by adding missing PR link and fix the code block

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 14, 2020
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 14, 2020
@richardlau
Copy link
Member

richardlau commented Jan 14, 2020

Was the missing PR link due to a bug in the changelog maker?

@BethGriggs
Copy link
Member

@richardlau, I don't think it was a bug, I think it was because I accidentally labelled 271b413 with Backport-PR-URL rather than PR-URL when it landed on staging. 😅

@Trott
Copy link
Member

Trott commented Jan 16, 2020

Landed in 5170daa

@Trott Trott closed this Jan 16, 2020
Trott pushed a commit that referenced this pull request Jan 16, 2020
PR-URL: #31358
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 27, 2020
PR-URL: #31358
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Mar 12, 2020
@targos targos added dont-land-on-v10.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants