addon: update NODE_MODULE_VERSION macro #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
io.js v1.0.0 is not ABI-compatible with joyent/[email protected], update the NODE_MODULE_VERSION macro to reflect that. Update to a much larger value to avoid future clashes with joyent/node. PR-URL: nodejs#312 Reviewed-By: Bert Belder <[email protected]>
|
lolgtm |
|
I prefer 9001 |
|
Or 3735928559 |
bnoordhuis
force-pushed
the
update-version-macro
branch
from
dc581a5
to
42ebdcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
io.js v1.0.0 is not ABI-compatible with joyent/[email protected], update
the NODE_MODULE_VERSION macro to reflect that. Update to a much
larger value to avoid future clashes with joyent/node.
R=@piscisaureus