Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: replace Set.prototype by SetPrototype primordials #31161

Closed
wants to merge 1 commit into from
Closed

lib: replace Set.prototype by SetPrototype primordials #31161

wants to merge 1 commit into from

Conversation

Sebastien-Ahkrin
Copy link
Contributor

Hello 😄

Just replaced every Set.prototype by SetPrototype in the lib/* folder
For this, i just have added SetPrototype in the import

const {
  // [...]
  SetPrototype,
} = primordials;

I hope this pull request will help you ! :P

@nodejs-github-bot nodejs-github-bot added the process Issues and PRs related to the process subsystem. label Jan 2, 2020
@Sebastien-Ahkrin
Copy link
Contributor Author

Refs: #30697

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 2, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28118/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28154/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 3, 2020 •
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/28172/ ✔️

@Trott
Copy link
Member

Trott commented Jan 4, 2020

Landed in e568403

@Trott Trott closed this Jan 4, 2020
Trott pushed a commit that referenced this pull request Jan 4, 2020
@Sebastien-Ahkrin @Trott
lib: replace Set.prototype with SetPrototype primordial
e568403 
PR-URL: #31161
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Jan 6, 2020
@Sebastien-Ahkrin @targos
lib: replace Set.prototype with SetPrototype primordial
1527796 
PR-URL: #31161
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@Sebastien-Ahkrin @targos
lib: replace Set.prototype with SetPrototype primordial
b1550a6 
PR-URL: #31161
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@Sebastien-Ahkrin @BethGriggs
lib: replace Set.prototype with SetPrototype primordial
61e794b 
PR-URL: #31161
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Sebastien-Ahkrin @nodejs-github-bot @Trott @jasnell @targos @cjihrig @BridgeAR @trivikr