Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v12.x] src: make --use-largepages a runtime option #31063

Closed
wants to merge 5 commits into from
Closed

[v12.x] src: make --use-largepages a runtime option #31063

wants to merge 5 commits into from

Commits on Dec 31, 2019

  1. src: make --use-largepages a runtime option 

    Moves the option that instructs Node.js to-remap its static code to
large pages from a configure-time option to a runtime option. This
should make it easy to assess the performance impact of such a change
without having to custom-build.

PR-URL: nodejs#30954
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Co-authored-by: David Carlier <[email protected]>
    @devnexen
    Gabriel Schulhof and devnexen committed Dec 31, 2019
    Configuration menu
    Copy the full SHA
    3dffd75 View commit details
    Browse the repository at this point in the history

  2. build: re-introduce --use-largepages as no-op 

    Re-introduce the build-time option as a no-op in order to retain
backward compatibility for LTS purposes.

Re: nodejs#31063 (review)
PR_URL: nodejs#31075
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
    Gabriel Schulhof committed Dec 31, 2019
    Configuration menu
    Copy the full SHA
    a06a137 View commit details
    Browse the repository at this point in the history

  3. build: switch realpath to pwd 

    PR-URL: nodejs#31095
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
    @bcoe
    bcoe authored and Gabriel Schulhof committed Dec 31, 2019
    Configuration menu
    Copy the full SHA
    40afe3d View commit details
    Browse the repository at this point in the history

  4. src: make large_pages node.cc include conditional 

    The usage of the relevant methods from the file is conditional so make
the include conditional too.

PR-URL: nodejs#31078
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
    @lundibundi
    lundibundi authored and Gabriel Schulhof committed Dec 31, 2019
    Configuration menu
    Copy the full SHA
    b74afb3 View commit details
    Browse the repository at this point in the history

  5. build: warn upon --use-largepages config option 

    Emit a warning when the user configures with `--use-largepages` and/or
`--use-largepages-script-lld` informing them that the option is now
available as a Node.js runtime option once it is built.

Refs: nodejs#31063 (comment)
PR-URL: nodejs#31103
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
    Gabriel Schulhof committed Dec 31, 2019
    Configuration menu
    Copy the full SHA
    c48f9d1 View commit details
    Browse the repository at this point in the history