lib: replace every Symbol.for by SymbolFor #30857
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
Sebastien-Ahkrin
force-pushed
the
SymbolFor
branch
3 times, most recently
from
52470c1
to
ebdc308
Compare
Sebastien-Ahkrin
force-pushed
the
SymbolFor
branch
from
ebdc308
to
163e874
Compare
targos
approved these changes
Dec 8, 2019
cjihrig
approved these changes
Dec 8, 2019
|
Refs: #30697 |
trivikr
approved these changes
Dec 9, 2019
targos
pushed a commit
that referenced
this pull request
Dec 11, 2019
PR-URL: #30857 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
|
Landed in 11465d3 |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 13, 2019
PR-URL: #30857 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
PR-URL: #30857 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
PR-URL: #30857 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just replacing every Symbol.for by SymbolFor in the lib/* folder
And adding SymbolFor in the import
This task was given to me by @targos thanks again ❤️
I hope this new PR will help you :x